Skip to content

Conversation

@OttoAllmendinger
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger commented Nov 4, 2025

This PR adds MuSig2 finalization support to our PSBT handling in the wasm-utxo
module:

  • Add proper parsing for BitGo PSBT extensions including structured parsing
    for Musig2 participants data, public nonces, and partial signatures

  • Add PSBT finalization support for MuSig2 with new finalize_input,
    finalize_mut, and finalize methods to BitGoPsbt for proper finalization of
    P2TR MuSig2 inputs

  • Export BitGoKeyValue and related constants from the propkv module

  • Add paste dependency to test dependencies for cleaner macro expansion in
    upcoming MuSig2 implementation

All changes include comprehensive test coverage with fixtures to verify proper
finalization and transaction extraction.

Issue: BTC-2652

OttoAllmendinger and others added 3 commits November 4, 2025 13:56
Add the paste crate to test dependencies to support cleaner test macro
expansion for upcoming MuSig2 implementation.

Issue: BTC-2652

Co-authored-by: llm-git <llm-git@ttll.de>
Add finalize_input, finalize_mut, and finalize methods to BitGoPsbt to support
proper finalization of P2TR MuSig2 inputs. Also export BitGoKeyValue and related
constants from the propkv module.

Includes comprehensive tests with fixtures to verify proper finalization and
transaction extraction.

Issue: BTC-2652

Co-authored-by: llm-git <llm-git@ttll.de>
Add structured parsing for Musig2 PSBT extensions:
- Participants data
- Public nonces
- Partial signatures

These are now displayed in a human-readable format in the CLI tool
instead of raw byte arrays.

Issue: BTC-2652

Co-authored-by: llm-git <llm-git@ttll.de>
@OttoAllmendinger OttoAllmendinger force-pushed the BTC-2652.p2tr-musig2.finalize branch from 1546199 to ddc0165 Compare November 4, 2025 12:56
@OttoAllmendinger OttoAllmendinger marked this pull request as ready for review November 4, 2025 13:03
@OttoAllmendinger OttoAllmendinger requested a review from a team as a code owner November 4, 2025 13:03
@OttoAllmendinger OttoAllmendinger changed the title feat(wasm-utxo): implement MuSig2 support for PSBT handling feat(wasm-utxo): implement MuSig2 finalization support for PSBT handling Nov 4, 2025
@OttoAllmendinger OttoAllmendinger merged commit 62cb38d into master Nov 4, 2025
1 check passed
@OttoAllmendinger OttoAllmendinger deleted the BTC-2652.p2tr-musig2.finalize branch November 4, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants